Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-45203: LokiStack gatherer #1051

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[release-4.16] OCPBUGS-45203: LokiStack gatherer #1051

merged 2 commits into from
Dec 18, 2024

Conversation

joselsegura
Copy link
Contributor

This is a manual cherry-pick of #1022 and #1043

/assign openshift-ci-robot

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 10, 2024
@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45202, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.z" instead
  • expected dependent Jira Issue OCPBUGS-45201 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-45201 to target a version in 4.17.0, 4.17.z, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #1022 and #1043

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ncaak and tremes December 10, 2024 09:20
@joselsegura
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 12, 2024
Merged
@joselsegura
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45202, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.z" instead
  • expected dependent Jira Issue OCPBUGS-45201 to target a version in 4.17.0, 4.17.z, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joselsegura joselsegura changed the title [release-4.16] OCPBUGS-45202: LokiStack gatherer [release-4.16] OCPBUGS-45203: LokiStack gatherer Dec 12, 2024
@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45203, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-45202 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #1022 and #1043

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joselsegura
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45203, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-45202 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joselsegura joselsegura force-pushed the cherry-pick-1022-to-release-4.16 branch from 49cf02e to 29069f5 Compare December 13, 2024 15:30
@joselsegura
Copy link
Contributor Author

/jira refresh

@joselsegura
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45203, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-45202 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joselsegura
OCPBUGS-45047: LokiStack gatherer (openshift#1022)
29dbdb1 
* Adding LokiStack gatherer

* Pay attention to error

* Gathering at most 20. Anonymizing the results to remove tenant's selectors

* Fix behaviour

* Solving some misunderstandings

* Make lintian happy again

* Updating docs

* Added unit tests

* Fix linter

* Tests table-strategy

* Fix linters

* Answering review
@joselsegura
OCPBUGS-45047: Avoid to send the same error repeated N times (openshi…
9df488d 
…ft#1043)

* Avoid to send the same error repeated N times

* Fix the LokiStack gatherer documentation
@joselsegura joselsegura force-pushed the cherry-pick-1022-to-release-4.16 branch from 29069f5 to 9df488d Compare December 16, 2024 07:42
@joselsegura
Copy link
Contributor Author

/test e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor

tremes commented Dec 16, 2024

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 16, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joselsegura, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@joselsegura
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 16, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 16, 2024
@openshift-ci-robot
Copy link
Contributor

@joselsegura: This pull request references Jira Issue OCPBUGS-45203, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-45202 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-45202 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

Requesting review from QA contact:
/cc @BaiyangZhou

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from BaiyangZhou December 16, 2024 11:39
@joselsegura
Copy link
Contributor Author

/test e2e-gcp-ovn-techpreview

@BaiyangZhou
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 18, 2024
@tremes
Copy link
Contributor

tremes commented Dec 18, 2024

/test e2e-gcp-ovn-techpreview

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024

@joselsegura: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5328a85 into openshift:release-4.16 Dec 18, 2024
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@joselsegura: Jira Issue OCPBUGS-45203: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45203 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #1022 and #1043

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-insights-operator
This PR has been included in build ose-insights-operator-container-v4.16.0-202412181404.p0.g5328a85.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-12-18-161525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak Awaiting requested review from ncaak

@tremes tremes Awaiting requested review from tremes

@BaiyangZhou BaiyangZhou Awaiting requested review from BaiyangZhou

Assignees

@tremes tremes

@openshift-ci-robot openshift-ci-robot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joselsegura @openshift-ci-robot @tremes @BaiyangZhou @openshift-bot @openshift-merge-robot